Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterQueue and Queue Metrics #199

Closed
4 tasks done
Tracked by #222
ahg-g opened this issue Apr 9, 2022 · 10 comments · Fixed by #315
Closed
4 tasks done
Tracked by #222

Add ClusterQueue and Queue Metrics #199

ahg-g opened this issue Apr 9, 2022 · 10 comments · Fixed by #315
Assignees
@alculquicondor
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/productionization kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Apr 9, 2022 •
edited
Loading

What would you like to be added:

Metrics to track:

  1. Queue/ClusterQueue pending workloads (gauge)
  2. Queue/ClusterQueue admitted workloads (gauge)
  3. Admission cycle latency (histogram)
  4. Workload waiting time in the queue (histogram)

what else?
@ahg-g ahg-g added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 9, 2022
@ahg-g ahg-g mentioned this issue Apr 10, 2022
Closed
@ahg-g ahg-g changed the title ClusterQueue and Queue Metrics Add ClusterQueue and Queue Metrics Apr 13, 2022
@ahg-g ahg-g mentioned this issue Apr 15, 2022
Closed
16 tasks
@kerthcet
Copy link
Contributor

/assign

@alculquicondor
Copy link
Contributor

Oops, I forgot to put my name on this. I was already working on it. I hope you don't mind @kerthcet?

@kerthcet
Copy link
Contributor

Plz go ahead.

@kerthcet
Copy link
Contributor

/unassign
/assign @alculquicondor

@kerthcet
Copy link
Contributor

kerthcet commented Apr 26, 2022 •
edited
Loading

I have nearly finished the Queue/ClusterQueue pending workloads (gauge), some tests left. if you haven't work on this one, I can finish this one to prevent redundant works. If not, please forget what I said.

@alculquicondor
Copy link
Contributor

/assign

This was referenced Apr 27, 2022
Merged
Merged
@ahg-g
Copy link
Contributor Author

ahg-g commented May 7, 2022 •
edited
Loading

Aldo, I guess the following represents progress on this issue, correct?

  1. Queue/ClusterQueue pending workloads (gauge)
  2. Admission cycle latency (histogram)
  3. Queue/ClusterQueue admitted workloads (gauge)
  4. Workload waiting time in the queue (histogram)

@alculquicondor
Copy link
Contributor

correct, thanks

@alculquicondor alculquicondor mentioned this issue May 12, 2022
Closed
3 tasks
@alculquicondor alculquicondor mentioned this issue Jul 7, 2022
Merged
@ahg-g
Copy link
Contributor Author

ahg-g commented Jul 18, 2022

@alculquicondor are you planning to add workload waiting time?

@alculquicondor
Copy link
Contributor

yes. But feel free to take that if you have time this week. Otherwise I'll do it next week.

@alculquicondor alculquicondor mentioned this issue Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alculquicondor alculquicondor

Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/productionization kind/ux priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metrics for total number of admissions and wait time alculquicondor/kueue
3 participants
@alculquicondor @kerthcet @ahg-g