Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod group: Replacement Pods should be added as Workload owners #1557

Closed
alculquicondor opened this issue Jan 8, 2024 · 3 comments · Fixed by #1683
Closed

Pod group: Replacement Pods should be added as Workload owners #1557

alculquicondor opened this issue Jan 8, 2024 · 3 comments · Fixed by #1683
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alculquicondor
Copy link
Contributor

alculquicondor commented Jan 8, 2024

What happened:

When a Pod fails, it can be replaced with a new pod. However, the new pod doesn't become an owner of the Workload.

This could lead to a Workload from disappearing before all the Pod finalizers have been removed.

What you expected to happen:

The replacement Pod should be owner of the Workload. Excess pods should not be owners.

How to reproduce it (as minimally and precisely as possible):

  1. Create pod group
  2. Fail one pod
  3. Create replacement pod

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Kueue version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@alculquicondor alculquicondor added the kind/bug Categorizes issue or PR as related to a bug. label Jan 8, 2024
@alculquicondor
Copy link
Contributor Author

cc @achernevskii

@alculquicondor
Copy link
Contributor Author

From @mimowo:

re-admitted workload gets deleted after completing. This is because the replacement pods don't become owners of the workload. So the workload gets deleted by garbage-collector very quickly

@mimowo
Copy link
Contributor

mimowo commented Jan 26, 2024

/assign
I would like to give it a try, continuing tasks related to pod groups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants