Skip to content

Commit

Permalink
Review remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
mimowo committed Sep 6, 2024
1 parent 42048d9 commit 0623107
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions keps/2724-topology-aware-schedling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ follow naturally we may as well support them in alpha.

One complication we noticed for JobSet is that the proposed design assumes
injecting the dedicated scheduling gate, called `kueue.x-k8s.io/topology` into
the PodTemplate. However, currently JobSet's `spec.replicatedJob` field is
immutable, even if the JobSet is suspended. This has been relaxed in JobSet 0.6
the PodTemplate. This required a JobSet fix which is released in 0.6
(see [PR](https://github.com/kubernetes-sigs/jobset/pull/623)).

#### Support for the "auto" mode
Expand Down Expand Up @@ -166,7 +165,8 @@ replacement node.
In order to mitigate this risk we propose to extend the waitForPodsReady
mechanism with a new timeout, called replacement timeout, which defines the
timeout for all pods to be ready again. The time is computed since the last
transition to the PodsReady=false, more details in the KEP PR. This mechanism
transition to the `PodsReady=false`, more details in the
[KEP PR](https://github.com/kubernetes-sigs/kueue/pull/2737). This mechanism
will also be helpful for regular workloads.

A more involving approach would be to recompute the TopologyAdmission, however,
Expand Down

0 comments on commit 0623107

Please sign in to comment.