Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud provider config to kubeadm deployments #3394

Closed
wants to merge 6 commits into from

Conversation

woopstar
Copy link
Member

@woopstar woopstar commented Sep 26, 2018

Add cloud provider to kubeadm deployments.

According to kubernetes/kubeadm#1018 (comment) the cloud provider config should be in the extra args of each control plane.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: woopstar

If they are not already assigned, you can assign the PR to them by writing /assign @woopstar in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2018
@woopstar
Copy link
Member Author

ci check this

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2018
@woopstar woopstar added this to the 2.7 milestone Sep 26, 2018
@woopstar woopstar changed the title Add cloud provider config to kubeadm deployments for v1alpha2 Add cloud provider config to kubeadm deployments Sep 26, 2018
@riverzhang
Copy link
Contributor

@woopstar kubelet_kubeadm.env, Also need to configure cloud_provider.

@riverzhang
Copy link
Contributor

Both apiserver and controllerManager need to mount cloud_config?

@woopstar
Copy link
Member Author

Both apiserver and controllerManager need to mount cloud_config?

They do ?

@riverzhang
Copy link
Contributor

I think need to do that, They are 2 containers. I don't know how to supports it by kubeadm.

@woopstar woopstar modified the milestones: 2.7, v2.8 Sep 26, 2018
@neith00
Copy link
Contributor

neith00 commented Oct 3, 2018

The deployment itself goes well.
On the opposite, I get tons of errors regarding TLS Handshakes when the liveness probe on the apiserver container is called. As a consequence, the apiserver keeps beeing restarted by the kubelet.
I tried using plain http on the probe and everything is going back to normal.
In fact I don't know if we must use HTTP or HTTPS for this probe. Let met all know what you think.
I tried to add the ca.crt to the system ca's but the probe keeps failing.

@riverzhang
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2018
@woopstar woopstar closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants