-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud provider config to kubeadm deployments #3394
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ci check this |
roles/kubernetes/master/templates/kubeadm-config.v1alpha1.yaml.j2
Outdated
Show resolved
Hide resolved
roles/kubernetes/master/templates/kubeadm-config.v1alpha1.yaml.j2
Outdated
Show resolved
Hide resolved
roles/kubernetes/master/templates/kubeadm-config.v1alpha2.yaml.j2
Outdated
Show resolved
Hide resolved
@woopstar kubelet_kubeadm.env, Also need to configure cloud_provider. |
roles/kubernetes/master/templates/kubeadm-config.v1alpha1.yaml.j2
Outdated
Show resolved
Hide resolved
Both apiserver and controllerManager need to mount cloud_config? |
They do ? |
I think need to do that, They are 2 containers. I don't know how to supports it by kubeadm. |
The deployment itself goes well. |
roles/kubernetes/master/templates/kubeadm-config.v1alpha1.yaml.j2
Outdated
Show resolved
Hide resolved
/hold |
Add cloud provider to kubeadm deployments.
According to kubernetes/kubeadm#1018 (comment) the cloud provider config should be in the extra args of each control plane.