Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Resolve target namespace of kubefedctl commad from kubeconfig context #1044

Closed
roytman opened this issue Jul 18, 2019 · 1 comment
Closed

Resolve target namespace of kubefedctl commad from kubeconfig context #1044

roytman opened this issue Jul 18, 2019 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@roytman
Copy link
Contributor

roytman commented Jul 18, 2019

What would you like to be added:
The federate and all orphaning-deletion commands need a namespace of the target <federated object>. From the user guide "If the flag --namespace is additionally not specified, the will be searched for in the namespace default". I'd suggest to use namespace from the client kubeconfig context, if the target namespace is not explicitly specified.

Why is this needed:
The current behavior inconsistent with the kubectl command.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2019
@roytman roytman mentioned this issue Jul 18, 2019
Merged
@roytman
Copy link
Contributor Author

roytman commented Jul 20, 2019

Fixed by #1045

@roytman roytman closed this as completed Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roytman @k8s-ci-robot