Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 upgrade CLI tool dep k8s.io/apimachinery from v0.21.2 to v0.22.1 used by alpha config-gen #2339

Closed
wants to merge 1 commit into from
Closed

🌱 upgrade CLI tool dep k8s.io/apimachinery from v0.21.2 to v0.22.1 used by alpha config-gen #2339

wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Sep 17, 2021 •
edited
Loading

Description
🌱 upgrade CLI tool dep k8s.io/apimachinery from v0.21.2 to v0.22.1 used by alpha config-gen

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2021
@camilamacedo86 camilamacedo86 changed the title (:sparkles:) : Upgrade CLI tool deps only 🌱 Upgrade CLI tool deps only Sep 17, 2021
@camilamacedo86 camilamacedo86 force-pushed the bump-kb-cli-dep branch 2 times, most recently from 61936eb to db26bb8 Compare September 17, 2021 01:06
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 17, 2021
Merged
2 tasks
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test
/test pull-kubebuilder-e2e-k8s-1-14-10
/test pull-kubebuilder-e2e-k8s-1-18-8

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 17, 2021
@camilamacedo86 camilamacedo86 changed the title 🌱 Upgrade CLI tool deps only 🌱 upgrade CLI tool dep k8s.io/apimachinery v0.21.2 used by alpha config-gen Sep 17, 2021
@camilamacedo86 camilamacedo86 changed the title 🌱 upgrade CLI tool dep k8s.io/apimachinery v0.21.2 used by alpha config-gen 🌱 upgrade CLI tool dep k8s.io/apimachinery from v0.21.2 to v0.22.1 used by alpha config-gen Sep 17, 2021
varshaprasad96
varshaprasad96 reviewed Sep 17, 2021
View reviewed changes
go.mod
@@ -12,7 +12,7 @@ require (
github.com/spf13/cobra v1.1.3
github.com/spf13/pflag v1.0.5
golang.org/x/tools v0.1.2
k8s.io/apimachinery v0.21.2 // for `kubebuilder alpha config-gen`
k8s.io/apimachinery v0.22.1 // for `kubebuilder alpha config-gen`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 just curious, why aren't we also bumping controller-runtime to 0.10.0 and controller-tools to 0.6.2 (the latest versions?)

Copy link
Member Author

@camilamacedo86 camilamacedo86 Sep 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create this PR just to update the tool.

I did another PR to update the scaffolds. See: #2340

However, we first need the kubernetes-sigs/controller-tools#607 then, to do a release there and then we can update here. Note that my goal here was clarified when the dep is used and it can also be closed with #2340

@camilamacedo86 camilamacedo86 mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 left review comments

@Adirio Adirio Awaiting requested review from Adirio

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @k8s-ci-robot @varshaprasad96