Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime to use client.Patch #656

Closed
pytimer opened this issue Mar 31, 2019 · 3 comments
Closed

Update controller-runtime to use client.Patch #656

pytimer opened this issue Mar 31, 2019 · 3 comments

Comments

@pytimer
Copy link

pytimer commented Mar 31, 2019

I use kubebuilder to create a controller to manage CRD, i want to use r.Patch() in controller Reconcile function, but i found the controller-runtime version is v0.1.1, it does not have Patch function.

The latest controller-runtime already implement Patch method, kubernetes-sigs/controller-runtime#235.
I want to ask, how to do if i want use the latest controller-runtime?

I already run dep ensure -v --update sigs.k8s.io/controller-runtime sigs.k8s.io/controller-tools, but it still v0.1.1 version.

kubebuilder version

$ kubebuilder version
Version: version.Version{KubeBuilderVersion:"1.0.8", KubernetesVendor:"1.13.1", GitCommit:"1adf50ed107f5042d7472ba5ab50d5e1d357169d", BuildDate:"2019-01-25T23:14:29Z", GoOs:"unknown", GoArch:"unknown"}
@DirectXMan12
Copy link
Contributor

Set your controller-runtime to the appropriate version in Gopkg.toml (in this case, you'd need to use branch="master" since that commit hasn't been released yet.

@DirectXMan12
Copy link
Contributor

(closing for now, feel free to comment if you have more questions)

@pytimer
Copy link
Author

pytimer commented Apr 9, 2019

Thanks for you reply. I change controller-runtime use the master branch, it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants