Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading kube-builder #650

Closed
itaysk opened this issue Mar 27, 2019 · 8 comments
Closed

upgrading kube-builder #650

itaysk opened this issue Mar 27, 2019 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@itaysk
Copy link

itaysk commented Mar 27, 2019

Is there an upgrade story for kube-builder? the gitbook talks about updating dependencies, but much of what kube-builder is is what's being scaffolded.
I don't know threre's a good colution for this but at least document changes so that people can manually apply.

@DirectXMan12
Copy link
Contributor

it's not particularly intended that people update their scaffolding (the scaffolding is one-time setup, or is supposed to be), but when we do the scaffolding v2 release, we'll be providing migration instructions if you want to move over to the simplified format.

Does that answer your question?

@itaysk
Copy link
Author

itaysk commented Apr 9, 2019

I asked this question because the scaffolding did in fact change over time and I had an issue that was fixed and I had to dig through issues and commit diffs to find how to manually apply the changes. Are changes to the scaffold such rare? (I mean, you guys know better then me, I'm just sharing from my experience)

@DirectXMan12
Copy link
Contributor

Scaffolding changes should be relatively rare, and it's not intended that we change scaffolding without reving the version if it's a breaking change. I'm curious as to which change you had to apply manually.

@itaysk
Copy link
Author

itaysk commented May 31, 2019

This is one issue that I remember of: #595

@DirectXMan12
Copy link
Contributor

ah, yeah... we don't really have a good story for dealing with that right now, unfortunately. I'm certainly open to suggestions though.

@DirectXMan12
Copy link
Contributor

/kind feature
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jun 4, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2019
@DirectXMan12
Copy link
Contributor

We've got a section for migration in the docs now. I don't foresee scaffolding changes being automatic, so closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants