Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(go/v5) Rename container commands from docker-<action> to container-<action> #4293

Open
mateusoliveira43 opened this issue Nov 5, 2024 · 1 comment
Open

(go/v5) Rename container commands from docker-<action> to container-<action> #4293

mateusoliveira43 opened this issue Nov 5, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/blocked
Milestone
go/v5

Comments

@mateusoliveira43
Copy link
Contributor

What do you want to happen?

kubebuilder scaffolds 2 container commands called docker-build and docker-push in Makefile. But they work with other container tools, like Podman, and not only with Docker (to change the container tool used by the commands, use the CONTAINER_TOOL variable in Makefile).

Would make sense to change command names to container-build and container-push then.

Part of changes needed were done here #4288. Would also need to change documentation and other places of the code base to fully apply the change

Extra Labels

No response
@mateusoliveira43 mateusoliveira43 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 5, 2024
@mateusoliveira43 mateusoliveira43 mentioned this issue Nov 5, 2024
Closed
@camilamacedo86 camilamacedo86 added this to the go/v5 milestone Nov 5, 2024
@camilamacedo86 camilamacedo86 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/blocked labels Nov 5, 2024
@camilamacedo86
Copy link
Member

We need a significant number of changes and requirements to initiate go/v5. Once these are in place, we can address this issue. Adding this one to the go/v5 milestone

@camilamacedo86 camilamacedo86 changed the title (go/v5) container friendly commands (go/v5) Rename container commands from docker-<action> to container-<action> Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/blocked
Projects
None yet
Milestone
go/v5
Development

No branches or pull requests
2 participants
@camilamacedo86 @mateusoliveira43