Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve PR description verifier #34

Closed
estroz opened this issue Jan 21, 2021 · 0 comments · Fixed by #36
Closed

improve PR description verifier #34

estroz opened this issue Jan 21, 2021 · 0 comments · Fixed by #36
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@estroz
Copy link

estroz commented Jan 21, 2021

The PR description verifier tool checks if a description is "descriptive" enough, i.e. >= 2 lines. This is kinda brittle because one long line is considered less descriptive than 2 short lines. Instead, I propose that a minimum character length (say, 80) be used to quantify descriptiveness.

Additionally there should be a way to override this check and have it pass on special PRs, ex. cherry picks, that typically have short descriptions.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants