Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexoperations methods should take environment.Paths #550

Closed
ahmetb opened this issue Mar 12, 2020 · 0 comments · Fixed by #552
Closed

indexoperations methods should take environment.Paths #550

ahmetb opened this issue Mar 12, 2020 · 0 comments · Fixed by #552
Assignees

Comments

@ahmetb
Copy link
Member

ahmetb commented Mar 12, 2020

While trying to refactor indexoperations in #549 and adding a DeleteIndex method I realized these methods should take environment.Paths value and use its method to construct paths to index dirs etc.

That's precisely why we created Paths and its methods: To avoid spread and duplication of FS layout of things and repetition of filepath.Joins all over the codebase. :)

/assign

I'll get to this once #549 is merged.
cc: @chriskim06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant