Cleanup: more consistent naming of inner *testing.T

[corneliusweig]

There are basically two patterns in krew:

1. Shadow the outer t *testing.T.

2. Use an inner tt *testing.T

Both variants have their pro's and con's:
Shadowing can be confusing because one might overlook that there is an inner variable that shadows the outer one. However, in the great majority of cases, only the inner *testing.T should be used for assertions, so this also prevents errors where a test uses the outer one. So either way is fine.

Let's decide which pattern we want to follow and stick to it. This should also come with a source code test.

[ahmetb]

Nr.2 for sure :P

[ahmetb]

Also, honestly it doesn't matter a whole lot.
It seems like we almost never need the t in the outer scope.
This is also something sort of hard to enforce, we probably shouldn't be in the business of handling this.

[corneliusweig]

So you suggest to simply ignore that we are using different patterns?

[ahmetb]

IMO this isn’t really a coding pattern. Simply a variable shadowing in different scopes. It currently seems harmless, and doesn’t lead to code duplication etc.

If it bothers you a lot, feel free to write some code to enforce it. Maybe there’s a pattern we can check.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[corneliusweig]

Go 1.14 has improved support for deferred cleanup routines in tests. This should also be handled, either here or elsewhere

[ahmetb]

#606 suggests using go1.14 as well. It sounds like we just need to go do it.
/lifecycle frozen