Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests about printing new plugins/available upgrades #474

Closed
ahmetb opened this issue Jan 27, 2020 · 1 comment
Closed

Add integration tests about printing new plugins/available upgrades #474

ahmetb opened this issue Jan 27, 2020 · 1 comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ahmetb
Copy link
Member

ahmetb commented Jan 27, 2020

Need some basic integration tests for the work in #457.

Mostly to handle corner cases like:

  • first update doesn't print anything
  • delete a plugin from index → update → detected as "new plugin"
  • install plugin "foo" → git reset --hard to a commit that has older "foo" → update → detected as "upgrade available" in the output.
  • +cases above, but invoked also when install is called.

/priority important-soon
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 27, 2020
@ahmetb
Copy link
Member Author

ahmetb commented Jan 29, 2020

Closed in #479.

@ahmetb ahmetb closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmetb @k8s-ci-robot