Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show smaller output for updated plugin list #473

Closed
ahmetb opened this issue Jan 27, 2020 · 2 comments · Fixed by #477
Closed

Show smaller output for updated plugin list #473

ahmetb opened this issue Jan 27, 2020 · 2 comments · Fixed by #477
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ahmetb
Copy link
Member

ahmetb commented Jan 27, 2020

cc: @artmello
With this new change we see this:

image

I think we can dramatically update the viewing experience by doing these:

  • show "Upgrades available" ONLY IF any of the listed plugins are installed.
  • for "New plugins available" , user doesn't care about version number, so ideally we should not show it.

Also we can play a little bit with the indentation.

Here's what I'm thinking:

Updated the local copy of plugin index.
  New plugins available:
    * net-forward
  Upgrades available for installed plugins:
    * auth-proxy v0.7.0 -> v1.0.0
    * tree v0.3.1 -> v0.4.0
Installing plugin: tree
[...]

Thoughts?

/good-first-issue
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 27, 2020
@ahmetb
Copy link
Member Author

ahmetb commented Jan 27, 2020

  • show "Upgrades available" ONLY IF any of the listed plugins are installed.

It seems like this is already the current behavior, apologies for misunderstanding.

@artmello
Copy link
Contributor

@ahmetb I agree about not showing version for new plugins. About indentation, I am afraid that the output can be too long with one plugin per line. If more people agree, maybe we can get back to the idea of single line output for some commands and multiple lines for update. I pushed one PR with the suggested changes if we want to try it to see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants