Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: duplicate test object cleanup #270

Closed
ahmetb opened this issue Jul 17, 2019 · 1 comment · Fixed by #283
Closed

minor: duplicate test object cleanup #270

ahmetb opened this issue Jul 17, 2019 · 1 comment · Fixed by #283
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ahmetb
Copy link
Member

ahmetb commented Jul 17, 2019

Looks like both pkg/receipt/receipt_test.go and pkg/info/info_test.go have this in-memory plugin + pluginName definition.

It would be good to dedupe this in a testdata/sampleplugin_test.go (exported identifier) and import here, I think.

/kind cleanup
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 17, 2019
@ahmetb ahmetb mentioned this issue Jul 18, 2019
Merged
@corneliusweig
Copy link
Contributor

Note: there are two todo items labeled with the issue number that should be addressed in this PR.

@ahmetb ahmetb mentioned this issue Jul 21, 2019
Merged
@corneliusweig corneliusweig mentioned this issue Feb 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/testutil: add in-memory Plugin builder ahmetb/krew
3 participants
@ahmetb @k8s-ci-robot @corneliusweig