Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Rename "krew remove" to "krew uninstall" #188

Closed
superbrothers opened this issue May 29, 2019 · 3 comments · Fixed by #189
Closed

Proposal: Rename "krew remove" to "krew uninstall" #188

superbrothers opened this issue May 29, 2019 · 3 comments · Fixed by #189

Comments

@superbrothers
Copy link
Contributor

krew has install command for installing a plugin. On the other hand, for uninstalling a plugin, krew has remove command, not uninstall command. This is not intuitive and I often get confused.

Therefore I propose that krew remove is renamed to krew uninstall.

$ kubectl krew uninstall -h
Uninstall one or more plugins.

Example:
  kubectl krew uninstall NAME [NAME...]

Remarks:
  Failure to uninstall a plugin will result in an error and exit immediately.

Usage:
  krew uninstall [flags]

We can also keep krew remove as an alias to krew uninstall.

FYI: In Helm 3, helm delete command has been renamed to helm uninstall command.

@corneliusweig
Copy link
Contributor

+1 if we keep the alias

@ahmetb
Copy link
Member

ahmetb commented May 29, 2019

Yeah, we can rename and make "remove" an alias instead.

@superbrothers
Copy link
Contributor Author

Thank you for your comments. So I’ll create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants