Upgrade containerd to 1.4-beta.0 #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
aojea
reviewed
May 15, 2020
| @@ -23,7 +23,7 @@ FROM ubuntu:20.04 | |||
|
|
|||
| # Configure containerd and runc binaries from kind-ci/containerd-nightlies repository | |||
| # The repository contains latest stable releases and nightlies built for multiple architectures | |||
| ARG CONTAINERD_VERSION="v1.3.3-14-g449e9269" | |||
| ARG CONTAINERD_VERSION="v1.4.0-beta.0-2-g6312b52d" | |||
There was a problem hiding this comment.
we can avoid installing socat, no?
|
Do you need me to test this out? Or were you able to reproduce? |
|
I've not tested yet, it'd be great if you could. |
|
/retest |
|
/retest |
|
still looks like the known CI / e2e test issues (kubectl attach, general poor performance doing e.g, builds |
|
one of the test cases is blocked on kubernetes/kubernetes#91045 :/ |
|
/retest |
1 similar comment
|
/retest |
|
/test all |
1 similar comment
|
/test all |
|
1.18 needs kubernetes/kubernetes#91045 |
|
@BenTheElder: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kind-e2e-kubernetes |
|
/retest |
|
I tried running locally but ran into I don't see this at HEAD |
🤕 #61 |
|
I see, so if I am reading that correctly its just a warning not an error? In that case here is the full error logs - the cluster doesn't get created |
|
can you export the logs, I don't see anything relevant in the snippet 🤔 |
|
seems containerd is not able to run the containers do you have cgroupsv2 instead v1? |
I think that means I have cgroup2 - let me know if there is a better command |
|
Kubernetes doesn't currently support cgroupsv2, when it does I'm not sure
how quickly we'll be able to.
Unfortunately this is a kernel boot option.
…On Thu, May 21, 2020, 09:14 John Howard ***@***.***> wrote:
$ grep cgroup /proc/filesystems
nodev cgroup
nodev cgroup2
I think that means I have cgroup2 - let me know if there is a better
command
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1599 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADKYP4LZJLZUGHFSP633RSVHODANCNFSM4NBLBUSA>
.
|
|
/retest |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes potential fix for #1560