Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy output crashes terminal #1892

Closed
bdomars opened this issue Oct 14, 2020 · 3 comments · Fixed by #1924
Closed

Fancy output crashes terminal #1892

bdomars opened this issue Oct 14, 2020 · 3 comments · Fixed by #1924
Labels
kind/external upstream bugs

Comments

@bdomars
Copy link

bdomars commented Oct 14, 2020

What happened:
Tried running kind create cluster and terminal just closes after a couple of lines of output.

What you expected to happen:
Get the normal output and terminal stays open.

How to reproduce it (as minimally and precisely as possible):
Run kind create cluster in the st terminal emulator.

Anything else we need to know?:
Verified that this works fine using gnome-terminal also works in st if I run it with the -q flag so it seems to me that it's the fancy output that st does not like.

Environment:

  • kind version: kind v0.9.0 go1.15.2 linux/amd64

  • Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:52:00Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.1", GitCommit:"206bcadf021e76c27513500ca24182692aabd17e", GitTreeState:"clean", BuildDate:"2020-09-14T07:30:52Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}
  • Docker version: Server Version: 19.03.13

  • OS (e.g. from /etc/os-release): Ubuntu 20.04.1 LTS

@bdomars bdomars added the kind/bug Categorizes issue or PR as related to a bug. label Oct 14, 2020
@BenTheElder
Copy link
Member

KIND respects https://en.wikipedia.org/wiki/Computer_terminal#Dumb_terminals (TERM=dumb) and https://no-color.org/

This sounds like a bug in your terminal emulator.

@BenTheElder
Copy link
Member

What TERM does st set? is there any way to identify running inside of st?

These "fancy" characters are unicode (utf8) + a few VT escape sequences, which should work fine in 2020, but we already automatically disable them in a few known-broken environments (e.g. travis-ci's tty emulation), if it's possible to detect st specifically we can add that.

@BenTheElder BenTheElder added kind/external upstream bugs and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 14, 2020
@bdomars
Copy link
Author

bdomars commented Oct 20, 2020

Yeah, this might also be a bug with st. They at least have some known issue with Xft causing it to crash with "colored emojis" whatever that means.

TERM is set to st-256color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/external upstream bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants