From 52bc8dcb86dc29848f7ead86be7d6f1138b26afd Mon Sep 17 00:00:00 2001 From: Xiao Liang Date: Wed, 19 Aug 2020 20:57:37 -0700 Subject: [PATCH 1/3] Fix broken link in images/node --- images/node/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/images/node/README.md b/images/node/README.md index a9566a0437..370945db11 100644 --- a/images/node/README.md +++ b/images/node/README.md @@ -1,6 +1,6 @@ ## images/node -See: [`pkg/build/node/node.go`][pkg/build/node/node.go], this +See: [`/pkg/build/nodeimage/build_impl.go`][/pkg/build/nodeimage/build_impl.go], this image is built programmatically with docker run / exec / commit for performance reasons with large artifacts. @@ -11,5 +11,5 @@ Roughly this image is [the base image](./../base), with the addition of: See [`node-image`][node-image.md] for more design details. -[pkg/build/node/node.go]: ./../../pkg/build/node/node.go +[/pkg/build/nodeimage/build_impl.go]: ./../../pkg/build/nodeimage/build_impl.go [node-image.md]: https://kind.sigs.k8s.io/docs/design/node-image From 1cd047faa7ee782c4dba30d9d0a139479860fe32 Mon Sep 17 00:00:00 2001 From: Xiao Liang Date: Wed, 19 Aug 2020 21:01:30 -0700 Subject: [PATCH 2/3] Remove leading slash in path --- images/node/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/images/node/README.md b/images/node/README.md index 370945db11..bba51b9770 100644 --- a/images/node/README.md +++ b/images/node/README.md @@ -1,6 +1,6 @@ ## images/node -See: [`/pkg/build/nodeimage/build_impl.go`][/pkg/build/nodeimage/build_impl.go], this +See: [`pkg/build/nodeimage/build_impl.go`][pkg/build/nodeimage/build_impl.go], this image is built programmatically with docker run / exec / commit for performance reasons with large artifacts. @@ -11,5 +11,5 @@ Roughly this image is [the base image](./../base), with the addition of: See [`node-image`][node-image.md] for more design details. -[/pkg/build/nodeimage/build_impl.go]: ./../../pkg/build/nodeimage/build_impl.go +[pkg/build/nodeimage/build_impl.go]: ./../../pkg/build/nodeimage/build_impl.go [node-image.md]: https://kind.sigs.k8s.io/docs/design/node-image From b28e7c564ffe920b209e59831b89385e8b7c2a1a Mon Sep 17 00:00:00 2001 From: Xiao Liang Date: Wed, 19 Aug 2020 21:03:41 -0700 Subject: [PATCH 3/3] Include both build and build_impl for doc --- images/node/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/images/node/README.md b/images/node/README.md index bba51b9770..a0c0f9c119 100644 --- a/images/node/README.md +++ b/images/node/README.md @@ -1,6 +1,7 @@ ## images/node -See: [`pkg/build/nodeimage/build_impl.go`][pkg/build/nodeimage/build_impl.go], this +See: [`pkg/build/nodeimage/build.go`][pkg/build/nodeimage/build.go] +and [`pkg/build/nodeimage/build_impl.go`][pkg/build/nodeimage/build_impl.go], this image is built programmatically with docker run / exec / commit for performance reasons with large artifacts. @@ -11,5 +12,6 @@ Roughly this image is [the base image](./../base), with the addition of: See [`node-image`][node-image.md] for more design details. +[pkg/build/nodeimage/build.go]: ./../../pkg/build/nodeimage/build.go [pkg/build/nodeimage/build_impl.go]: ./../../pkg/build/nodeimage/build_impl.go [node-image.md]: https://kind.sigs.k8s.io/docs/design/node-image