diff --git a/pkg/cluster/config/types.go b/pkg/cluster/config/types.go index bd789e4762..11d2398b61 100644 --- a/pkg/cluster/config/types.go +++ b/pkg/cluster/config/types.go @@ -31,6 +31,9 @@ type Cluster struct { metav1.TypeMeta // Nodes contains the list of nodes defined in the `kind` Cluster + // If unset this will default to a single control-plane node + // Note that if more than one control plane is specified, an external + // control plane load balancer will be provisioned implicitly Nodes []Node /* Advanced fields */ @@ -57,6 +60,7 @@ type Node struct { Role NodeRole // Image is the node image to use when creating this node + // If unset a default image will be used, see defaults.Image Image string /* Advanced fields */ diff --git a/pkg/cluster/config/v1alpha2/types.go b/pkg/cluster/config/v1alpha2/types.go index 968429b63f..2ff2b81627 100644 --- a/pkg/cluster/config/v1alpha2/types.go +++ b/pkg/cluster/config/v1alpha2/types.go @@ -31,6 +31,9 @@ type Config struct { metav1.TypeMeta `json:",inline"` // nodes contains the list of nodes defined in the `kind` Config + // If unset this will default to a single control-plane node + // Note that if more than one control plane is specified, an external + // control plane load balancer will be provisioned implicitly Nodes []Node `json:"nodes"` } @@ -45,7 +48,7 @@ type Node struct { // Defaults to "control-plane" Role NodeRole `json:"role,omitempty"` // Image is the node image to use when running the cluster - // TODO(bentheelder): split this into image and tag? + // If unset a default image will be used, see defaults.Image Image string `json:"image,omitempty"` // KubeadmConfigPatches are applied to the generated kubeadm config as // strategic merge patches to `kustomize build` internally diff --git a/pkg/cluster/config/v1alpha3/types.go b/pkg/cluster/config/v1alpha3/types.go index 5b0e51c6f0..f4678d4fdc 100644 --- a/pkg/cluster/config/v1alpha3/types.go +++ b/pkg/cluster/config/v1alpha3/types.go @@ -31,6 +31,9 @@ type Cluster struct { metav1.TypeMeta `json:",inline"` // Nodes contains the list of nodes defined in the `kind` Cluster + // If unset this will default to a single control-plane node + // Note that if more than one control plane is specified, an external + // control plane load balancer will be provisioned implicitly Nodes []Node `json:"nodes"` /* Advanced fields */ @@ -57,6 +60,7 @@ type Node struct { Role NodeRole `json:"role,omitempty"` // Image is the node image to use when creating this node + // If unset a default image will be used, see defaults.Image Image string `json:"image,omitempty"` /* Advanced fields */