Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding volume operation metrics #276

Closed
verult opened this issue May 28, 2019 · 5 comments
Closed

Adding volume operation metrics #276

verult opened this issue May 28, 2019 · 5 comments
Assignees
Milestone

Comments

@verult
Copy link
Contributor

verult commented May 28, 2019

Does the CSI driver need Prometheus metrics?

Possible metrics:

  • GCP cloud provider calls
    • latency and error rates of GCE PD calls. We can compare the latency against the corresponding k8s volume operation latency to discover inefficiencies.
    • latency and error rates AltTokenSource oauth calls
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2019
@davidz627 davidz627 added this to the GA milestone Sep 18, 2019
@davidz627 davidz627 changed the title Adding metrics Adding volume operation metrics Sep 18, 2019
@davidz627
Copy link
Contributor

/remove-lifecycle stale
/assign @saad-ali

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2020
@davidz627
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2020
@saad-ali
Copy link
Contributor

CSI Metrics were added to the side car containers in the following PRs:

These PRs are available in the following sidecar releases:

  • external-provisioner v1.5.0+
  • external-attacher v2.1.0+
  • external-snapshotter v2.0.0+
  • external-resizer v0.4.0+

Distributors of this driver who want to enable the CSI Metrics should 1) ensure they deploy the correct version of the side car containers (see above), and 2) ensure the metrics-address and metrics-path flags are set for each of the sidecar containers specified above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants