-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant docs cleanup and refresh #2691
Conversation
8b78867
to
9712e55
Compare
Recommend spending some time looking at the deploy preview when reviewing this one: https://deploy-preview-2691--kubernetes-sigs-gateway-api.netlify.app/. Adding a hold since this is a big PR and want to give people a chance to look through it. /hold |
Nice, this LGTM (as long as it merges after #2689 and I don't have to rebase 😄 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from one thing, so I'll leave this for another round of changes, sorry @robscott.
- geps/gep-851/index.md | ||
- geps/gep-1323/index.md | ||
- geps/gep-1364/index.md | ||
- Enhancements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make more sense to have this section sorted in roughly declining order of stability? I'm thinking:
- Memorandum
- Standard
- Experimental
- Implementable
- Provisional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR is big enough to conflict with ~everything docs related, I'm going to merge as is and make a follow up for this detail so I don't have to do any more rebases.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Will make a follow up PR to address @youngnick's final comment, but getting this in now to avoid more rebasing. /hold cancel |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR is pretty massive, here's an attempt at a changelog:
Logo and Design
Mesh
gateway-api.sigs.k8s.io/mesh
will get you to this sectionLayout
Docs Consistency
Misc
Which issue(s) this PR fixes:
Fixes #2553
Does this PR introduce a user-facing change?: