Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify semantics when port_redirect is unset #1740

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Clarify semantics when port_redirect is unset #1740

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bf771a
Clarify semantics when port_redirect is unset
arkodg Feb 17, 2023
f5cbbb8
also clarify empty host_redirect case
arkodg Feb 17, 2023
5297de1
update based on GAPI community meeting guidance
arkodg Feb 28, 2023
89250ac
gen crds
arkodg Feb 28, 2023
4d51132
incorporate Nick's suggestion
arkodg Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apis/v1beta1/httproute_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,8 @@ type HTTPRequestRedirectFilter struct {

// Hostname is the hostname to be used in the value of the `Location`
// header in the response.
// When empty, the hostname of the request is used.
// When empty, the hostname in the `Host` header
// of the request is used.
//
// Support: Core
//
Expand All @@ -901,7 +902,8 @@ type HTTPRequestRedirectFilter struct {

// Port is the port to be used in the value of the `Location`
// header in the response.
// When empty, port (if specified) of the request is used.
// When empty, port (if specified) in the `Host` header
arkodg marked this conversation as resolved.
Show resolved Hide resolved
// of the request is used.
//
// Support: Extended
//
Expand Down