From fb117b01f280f51402ecde4ce8530a2bb09fbfec Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Thu, 26 Jan 2023 09:37:48 +0530 Subject: [PATCH 01/11] Update shared_types.go --- apis/v1beta1/shared_types.go | 1 + 1 file changed, 1 insertion(+) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index 2cd09f0832..4c146da09a 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -264,6 +264,7 @@ const ( // * "RefNotPermitted" // * "InvalidKind" // * "BackendNotFound" + // * "Cross-namespace ParentRef" // // Controllers may raise this condition with other reasons, // but should prefer to use the reasons listed above to improve From 19a7de286a94ab12e642caff06c3a4d7050df0f7 Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Fri, 27 Jan 2023 08:56:15 +0530 Subject: [PATCH 02/11] Update shared_types.go --- apis/v1beta1/shared_types.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index 4c146da09a..baf363b00d 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -264,7 +264,7 @@ const ( // * "RefNotPermitted" // * "InvalidKind" // * "BackendNotFound" - // * "Cross-namespace ParentRef" + // * "ParentRefNotPermitted" // // Controllers may raise this condition with other reasons, // but should prefer to use the reasons listed above to improve @@ -289,6 +289,12 @@ const ( // This reason is used with the "ResolvedRefs" condition when one of the // Route's rules has a reference to a resource that does not exist. RouteReasonBackendNotFound RouteConditionReason = "BackendNotFound" + + //This reason is used with the "ResolvedRef" condition when one of + // route has not been accepted because a ParentRef references a Gateway + //in another namespace, but no ReferenceGrant allows such a reference. + RouteReasonRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" + ) // RouteParentStatus describes the status of a route with respect to an From eed7adc021a746ad820d577ee8ad51d969045d4c Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Sun, 29 Jan 2023 18:38:44 +0530 Subject: [PATCH 03/11] Update shared_types.go --- apis/v1beta1/shared_types.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index baf363b00d..b069430222 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -293,7 +293,7 @@ const ( //This reason is used with the "ResolvedRef" condition when one of // route has not been accepted because a ParentRef references a Gateway //in another namespace, but no ReferenceGrant allows such a reference. - RouteReasonRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" + RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" ) From b37246d3e3a85ba9a9dbe34772b33a79f623806e Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Tue, 31 Jan 2023 10:27:21 +0000 Subject: [PATCH 04/11] code-formatted --- apis/v1beta1/shared_types.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index b069430222..703cc79d1b 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -289,12 +289,11 @@ const ( // This reason is used with the "ResolvedRefs" condition when one of the // Route's rules has a reference to a resource that does not exist. RouteReasonBackendNotFound RouteConditionReason = "BackendNotFound" - + //This reason is used with the "ResolvedRef" condition when one of - // route has not been accepted because a ParentRef references a Gateway + // route has not been accepted because a ParentRef references a Gateway //in another namespace, but no ReferenceGrant allows such a reference. - RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" - + RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" ) // RouteParentStatus describes the status of a route with respect to an From a412d5efaf0e0a9c55a0310ade624c23eae5daea Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Tue, 31 Jan 2023 17:25:09 +0530 Subject: [PATCH 05/11] Update shared_types.go --- apis/v1beta1/shared_types.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index 703cc79d1b..1cd52ead4c 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -215,7 +215,8 @@ const ( // * "NoMatchingListenerHostname" // * "NoMatchingParent" // * "UnsupportedValue" - // + // * "ParentRefNotPermitted" + // Possible reasons for this condition to be Unknown are: // // * "Pending" @@ -251,6 +252,11 @@ const ( // This reason is used with the "Accepted" when a controller has not yet // reconciled the route. RouteReasonPending RouteConditionReason = "Pending" + + //This reason is used with the "ResolvedRef" condition when one of + // route has not been accepted because a ParentRef references a Gateway + //in another namespace, but no ReferenceGrant allows such a reference. + RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" // This condition indicates whether the controller was able to resolve all // the object references for the Route. @@ -264,7 +270,6 @@ const ( // * "RefNotPermitted" // * "InvalidKind" // * "BackendNotFound" - // * "ParentRefNotPermitted" // // Controllers may raise this condition with other reasons, // but should prefer to use the reasons listed above to improve @@ -290,10 +295,6 @@ const ( // Route's rules has a reference to a resource that does not exist. RouteReasonBackendNotFound RouteConditionReason = "BackendNotFound" - //This reason is used with the "ResolvedRef" condition when one of - // route has not been accepted because a ParentRef references a Gateway - //in another namespace, but no ReferenceGrant allows such a reference. - RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" ) // RouteParentStatus describes the status of a route with respect to an From 005e9cdf268e9ad644bacab817aaf3cbb9328ecd Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Tue, 31 Jan 2023 14:49:39 +0000 Subject: [PATCH 06/11] code-formatted --- apis/v1beta1/shared_types.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index 1cd52ead4c..f04c85ca1f 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -252,7 +252,7 @@ const ( // This reason is used with the "Accepted" when a controller has not yet // reconciled the route. RouteReasonPending RouteConditionReason = "Pending" - + //This reason is used with the "ResolvedRef" condition when one of // route has not been accepted because a ParentRef references a Gateway //in another namespace, but no ReferenceGrant allows such a reference. @@ -294,7 +294,6 @@ const ( // This reason is used with the "ResolvedRefs" condition when one of the // Route's rules has a reference to a resource that does not exist. RouteReasonBackendNotFound RouteConditionReason = "BackendNotFound" - ) // RouteParentStatus describes the status of a route with respect to an From c0cf7c39389e9bafde171a92303cab276102080d Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Tue, 31 Jan 2023 21:08:25 +0530 Subject: [PATCH 07/11] Update apis/v1beta1/shared_types.go Co-authored-by: Shane Utt <shane@shaneutt.com> --- apis/v1beta1/shared_types.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index f04c85ca1f..c1228428c8 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -216,7 +216,7 @@ const ( // * "NoMatchingParent" // * "UnsupportedValue" // * "ParentRefNotPermitted" - + // // Possible reasons for this condition to be Unknown are: // // * "Pending" From 03835f526668184be0110067141171f0c4f46cd7 Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Tue, 31 Jan 2023 21:08:34 +0530 Subject: [PATCH 08/11] Update apis/v1beta1/shared_types.go Co-authored-by: Shane Utt <shane@shaneutt.com> --- apis/v1beta1/shared_types.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index c1228428c8..207a736855 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -253,9 +253,9 @@ const ( // reconciled the route. RouteReasonPending RouteConditionReason = "Pending" - //This reason is used with the "ResolvedRef" condition when one of + // This reason is used with the "ResolvedRef" condition when one of // route has not been accepted because a ParentRef references a Gateway - //in another namespace, but no ReferenceGrant allows such a reference. + // in another namespace, but no ReferenceGrant allows such a reference. RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" // This condition indicates whether the controller was able to resolve all From adbcf8489c7838c1f3b0199093e39b4e87469728 Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Tue, 31 Jan 2023 22:57:49 +0530 Subject: [PATCH 09/11] Update apis/v1beta1/shared_types.go Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com> --- apis/v1beta1/shared_types.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index 207a736855..fa874ed2dd 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -253,9 +253,9 @@ const ( // reconciled the route. RouteReasonPending RouteConditionReason = "Pending" - // This reason is used with the "ResolvedRef" condition when one of - // route has not been accepted because a ParentRef references a Gateway - // in another namespace, but no ReferenceGrant allows such a reference. + // This reason is used with the "Accepted" condition when the route has not + // been accepted by a Gateway because it has a cross-namespace parentRef, + // but no ReferenceGrant in the other namespace allows such a reference. RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" // This condition indicates whether the controller was able to resolve all From eb30231122fd7ab621e1f2f2055c93997d3a2437 Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Wed, 1 Feb 2023 06:35:36 +0530 Subject: [PATCH 10/11] Update shared_types.go --- apis/v1beta1/shared_types.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index fa874ed2dd..07069db3d1 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -248,16 +248,17 @@ const ( // This reason is used with the "Accepted" condition when a value for an Enum // is not recognized. RouteReasonUnsupportedValue RouteConditionReason = "UnsupportedValue" - - // This reason is used with the "Accepted" when a controller has not yet - // reconciled the route. - RouteReasonPending RouteConditionReason = "Pending" - + // This reason is used with the "Accepted" condition when the route has not // been accepted by a Gateway because it has a cross-namespace parentRef, // but no ReferenceGrant in the other namespace allows such a reference. RouteReasonParentRefNotPermitted RouteConditionReason = "ParentRefNotPermitted" + // This reason is used with the "Accepted" when a controller has not yet + // reconciled the route. + RouteReasonPending RouteConditionReason = "Pending" + + // This condition indicates whether the controller was able to resolve all // the object references for the Route. // From de2db1410319890b53311f5ca17a36bcda103112 Mon Sep 17 00:00:00 2001 From: Sajiyah Salat <109643863+Sajiyah-Salat@users.noreply.github.com> Date: Wed, 1 Feb 2023 01:08:55 +0000 Subject: [PATCH 11/11] code-formatted --- apis/v1beta1/shared_types.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apis/v1beta1/shared_types.go b/apis/v1beta1/shared_types.go index 07069db3d1..f973e4b329 100644 --- a/apis/v1beta1/shared_types.go +++ b/apis/v1beta1/shared_types.go @@ -248,7 +248,7 @@ const ( // This reason is used with the "Accepted" condition when a value for an Enum // is not recognized. RouteReasonUnsupportedValue RouteConditionReason = "UnsupportedValue" - + // This reason is used with the "Accepted" condition when the route has not // been accepted by a Gateway because it has a cross-namespace parentRef, // but no ReferenceGrant in the other namespace allows such a reference. @@ -258,7 +258,6 @@ const ( // reconciled the route. RouteReasonPending RouteConditionReason = "Pending" - // This condition indicates whether the controller was able to resolve all // the object references for the Route. //