Challenge with gateway.networking.k8s.io/gateway-name label for merged Gateways

[zhaohuabing]

According to GEP-1762, it requires that:

MUST label all generated resources (Service, Deployment, etc) with gateway.networking.k8s.io/gateway-name: my-gateway (where my-gateway is the name of the Gateway resource).

When implementing this in Envoy Gateway, we encounter a challenge with the generated resources that represent multiple merged Gateways. Currently, we concatenate the Gateway names like "gateway.networking.k8s.io/gateway-name: gateway1_gateway2". It would be beneficial to define a canonical way in the GEP for guidance.

Alternatively, we could consider using gateway.networking.k8s.io/gatewayclass-name: my-gatewayclass for generated resources of merged Gateways.

[howardjohn]

FWIW in Istio we have one primary gateway, the rest are merged into it. We use that as the label.

otherwise, not sure how you implement things like Gateway.spec.address?

[zhaohuabing]

Hi @howardjohn By merged Gateway, I mean Envoy Gateway deploys multiple Gateways resources onto a single EnvoyProxy fleet. There's no "primary gateway", each Gateway is still a standalone resource. Regarding Gateway.spec.address, EG uses the first address for ClusterIP type and all addresses for LoadBalancer type.

Could you please point me to the docs about Istio "primary gateway"? I didn't find it on this page Configuring ingress using a gateway.

[howardjohn]

Regarding Gateway.spec.address, EG uses the first address for ClusterIP type and all addresses for LoadBalancer type.

So the 'first' one is the primary one essentially..?

For istio
https://istio.io/latest/docs/tasks/traffic-management/ingress/gateway-api/#automated-deployment is the doc. You cannot merge automated gateways, only 0 or 1 automated and N manual. So at most one thing controls the infrastructure.

[arkodg]

@zhaohuabing, for Envoy Gateway, the gateway.networking.k8s.io/gateway-name label doesnt apply to the mergeGateways case since the paramatersRef being taken into consideration is the one in GatewayClass and not in Gateway (infrastructure.parametersRef is nil)

[zhaohuabing]

@zhaohuabing, for Envoy Gateway, the gateway.networking.k8s.io/gateway-name label doesnt apply to the mergeGateways case since the paramatersRef being taken into consideration is the one in GatewayClass and not in Gateway (infrastructure.parametersRef is nil)

Yes, agree. We don't need to add this label to the merged gateway. I'm going to close this issue.