Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support protobuf #3346

Closed
qicz opened this issue Sep 19, 2024 · 4 comments
Closed

support protobuf #3346

qicz opened this issue Sep 19, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@qicz
Copy link

qicz commented Sep 19, 2024

What would you like to be added:

Why this is needed:
client-go read resource will get better performance
@qicz qicz added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 19, 2024
This was referenced Sep 19, 2024
Closed
Closed
@howardjohn
Copy link
Contributor

I don't think the api-server supports reading CRDs as protobuf

@qicz
Copy link
Author

qicz commented Sep 20, 2024 •
edited
Loading

xref: kubernetes-sigs/aws-ebs-csi-driver#2138
https://kubernetes.io/docs/reference/using-api/api-concepts/#alternate-representations-of-resources
@howardjohn

@howardjohn
Copy link
Contributor

yeah that works for core types not crd

@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 20, 2024
@shaneutt shaneutt moved this to Triage in Post-GA Refinement Sep 20, 2024
@qicz
Copy link
Author

qicz commented Sep 25, 2024

just support core types by protobuf

Not all API resource types support Protobuf; specifically, Protobuf isn't available for resources that are defined as [CustomResourceDefinitions](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/) or are served via the [aggregation layer](https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/apiserver-aggregation/).

Controller-runtime based clients already use protobuf for types. kubernetes-sigs/controller-runtime#1149

using informer support core types and crd.

@qicz qicz closed this as completed Sep 25, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Post-GA Refinement Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Post-GA Refinement
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@howardjohn @qicz @shaneutt