Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Query Param Matching #259

Closed
robscott opened this issue Aug 7, 2020 · 4 comments · Fixed by #631
Closed

Support Query Param Matching #259

robscott opened this issue Aug 7, 2020 · 4 comments · Fixed by #631
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@robscott
Copy link
Member

robscott commented Aug 7, 2020

What would you like to be added:
It may be helpful to extend matching to support query parameters. Although not as common as header matching, this could be useful in some cases.

Why is this needed:
From what I can tell, some proxy implementations support query param matching but definitely not all. If we support this it will likely have to be an extended feature.
@robscott robscott added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2020
@hbagdi
Copy link
Contributor

hbagdi commented Oct 13, 2020

This and HTTP method based matching -- these two good candidates that could have custom conformance and use the extensionRef inside HTTPRouteMatch. If anyone takes this up, would love to get some feedback on the extension point.

@SantoDE
Copy link
Contributor

SantoDE commented Oct 14, 2020

Traefik is able to do QueryPath matching. We're currently doing a base implementation on the Spec. We could think about experimenting with the extension afterwards to support Query Param Matching?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2021
@hbagdi
Copy link
Contributor

hbagdi commented Jan 12, 2021

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 12, 2021
@robscott robscott added this to the v0.3.0 milestone Mar 24, 2021
@robscott robscott added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 14, 2021
@robscott robscott mentioned this issue Apr 23, 2021
Merged
@robscott robscott removed this from the v0.3.0 milestone Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding QueryParam matching to HTTPRoute robscott/gateway-api
5 participants
@robscott @SantoDE @hbagdi @k8s-ci-robot @fejta-bot