Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance test for PartiallyInvalid Route #2458

Open
robscott opened this issue Oct 6, 2023 · 2 comments
Open

Add conformance test for PartiallyInvalid Route #2458

robscott opened this issue Oct 6, 2023 · 2 comments
Labels
area/conformance lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@robscott
Copy link
Member

robscott commented Oct 6, 2023

What would you like to be added:
As suggested by @sunjayBhatia, we should figure out how to add conformance test coverage for #2429.

Before we do this we need to determine some kind of value that is considered invalid by implementations but passes CEL validation. Unclear what that will look like, and this will definitely require broader discussion.

Once that's in place (copied from #2429 (review)):

  • Add a new core feature, SupportsPartiallyInvalidRoutes (name tbd) and test that makes sure the status is set to true when there is a partially invalid route, likely ignoring reason/message
  • Add a couple new extended features, SupportsPartiallyInvalidRoutes[DropRule|Fallback]
    Implementations would opt-in to the test they support
  • We can modify a route to becoming partially invalid and test the invalid rule is dropped or the old configuration is respected, depending on what test is run
  • Status checked for the right values depending on what test is run

Why this is needed:
The spec change in #2429 introduces a new requirement for all implementations. Although it won't be trivial, it would be good to have conformance test coverage for this.

@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 9, 2023
@shaneutt shaneutt added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 8, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants