Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: always check gateway positive-polarity conditions #2415

Closed
mlavacca opened this issue Sep 21, 2023 · 4 comments · Fixed by #2443
Closed

conformance: always check gateway positive-polarity conditions #2415

mlavacca opened this issue Sep 21, 2023 · 4 comments · Fixed by #2443
Assignees
@levikobi
Labels
area/conformance release-blocker MUST be completed to complete the milestone triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v1.0.0

Comments

@mlavacca
Copy link
Member

What would you like to be added:

All the conformance tests that create a properly working Gateway, should always check the following three positive-polarity conditions are set to true, as stated here:

  • ResolvedRefs
  • Accepted
  • Programmed

The ResolvedRefs is going to be always checked by #2247 .
Some tests check only Accepted (e.g., https://github.com/mlavacca/gateway-api/blob/8ab4e18ca73533793f8a5d4e8c4248626b4690bf/conformance/tests/gateway-with-attached-routes.go#L114)
Some test check only Programmed (e.g., https://github.com/mlavacca/gateway-api/blob/8ab4e18ca73533793f8a5d4e8c4248626b4690bf/conformance/tests/gateway-secret-reference-grant-specific.go#L54)

Why this is needed:

We need to consistently check that all the valid gateways have all the three positive-polarity conditions always set to true.
@mlavacca mlavacca mentioned this issue Sep 21, 2023
Merged
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 21, 2023
@levikobi
Copy link
Member

I can take this one if thats ok

@shaneutt
Copy link
Member

Reading this one over, yes @levikobi I think it's ready to go.

/triage accepted
/assign @levikobi

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 21, 2023
@shaneutt shaneutt removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 21, 2023
@shaneutt shaneutt moved this from Triage to In Progress in Gateway API: The Road to GA Sep 21, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Sep 21, 2023
@shaneutt shaneutt added the release-blocker MUST be completed to complete the milestone label Sep 27, 2023
@shaneutt
Copy link
Member

@levikobi how are things going on this, do you need any assistance?

@levikobi levikobi mentioned this issue Sep 28, 2023
Merged
@levikobi
Copy link
Member

@shaneutt I'm good, thanks!
I think I've finished it, waiting for review

@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA Oct 5, 2023
@LiorLieberman LiorLieberman mentioned this issue Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@levikobi levikobi

Labels
area/conformance release-blocker MUST be completed to complete the milestone triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Check gateway positive-polarity conditions levikobi/gateway-api
4 participants
@shaneutt @k8s-ci-robot @mlavacca @levikobi