generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TargetREf in Policy GEP #2147
Labels
blocked
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Milestone
Comments
shaneutt
added
the
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
label
Jun 26, 2023
I think that #2128 needs to merge before we make any more Policy changes. After that, yes, this should update GEP-713. |
/triage accepted |
k8s-ci-robot
added
the
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
label
Aug 10, 2023
shaneutt
added
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Aug 10, 2023
looks like @zhaohuabing is driving this, thanks ! |
completed with #2283 |
9 tasks
github-project-automation
bot
moved this from In Progress
to Done
in Gateway API: The Road to GA
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Discussion generated from GEP-1897 points out that TargetRef could use some updates.
gateway-api/apis/v1alpha2/policy_types.go
Lines 24 to 41 in a33a934
SectionName
and/orPort
in TargetRef following the same mechanics ofParentRef
Then we can provide additional
TargetRef
types that extend the baseTargetRef
with the different possible combinations of these fields. That feels like it could be handled in a separate smaller update to the policy GEP.Originally posted by @robscott in #2113 (comment)
The text was updated successfully, but these errors were encountered: