Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conformance tests to handle the update in port redirect semantics #1805

Closed
arkodg opened this issue Mar 10, 2023 · 3 comments · Fixed by #1880
Closed

Update conformance tests to handle the update in port redirect semantics #1805

arkodg opened this issue Mar 10, 2023 · 3 comments · Fixed by #1880
Assignees
Labels
area/conformance priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker MUST be completed to complete the milestone triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Mar 10, 2023

What would you like to be added:
With an update in the API around port redirect semantics with #1740, the conformance tests pertaining to port redirect do not match this behavior and need to be updated here

Here are the additional cases that need to be addressed

  • Port specified in the redirect, and it’s not 80 or 443
  • Port specified in the redirect and it is 80 or 443
  • No port specified, Listener is 80 or 443
  • No port specified, Listener is not 80 or 443

Why this is needed:
To ensure conformance test are evaluating the API correctly

@shaneutt shaneutt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 10, 2023
@shaneutt shaneutt added this to the v0.7.0 milestone Mar 10, 2023
@robscott robscott added the release-blocker MUST be completed to complete the milestone label Mar 23, 2023
@arkodg
Copy link
Contributor Author

arkodg commented Mar 27, 2023

/assign @gauravkghildiyal

@k8s-ci-robot
Copy link
Contributor

@arkodg: GitHub didn't allow me to assign the following users: gauravkghildiyal.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gauravkghildiyal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gauravkghildiyal
Copy link
Member

/assign

@shaneutt shaneutt moved this from Next to In Progress in Gateway API: The Road to GA Mar 28, 2023
@shaneutt shaneutt modified the milestones: v0.7.0, v0.7.1 Apr 6, 2023
@shaneutt shaneutt modified the milestones: v0.7.1, v0.7.0 May 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker MUST be completed to complete the milestone triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants