Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide documentation/guide to explain usage of ParentRef.Port #1021

Closed
cxhiano opened this issue Feb 15, 2022 · 1 comment · Fixed by #1082
Closed

Provide documentation/guide to explain usage of ParentRef.Port #1021

cxhiano opened this issue Feb 15, 2022 · 1 comment · Fixed by #1082
Assignees
@cxhiano
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Milestone
v0.5.0

Comments

@cxhiano
Copy link
Contributor

cxhiano commented Feb 15, 2022

What would you like to be added:

A documentation/guide to explain usage of ParentRef.Port

Why this is needed:
gep-957 proposed to add Port to ParentRef, in addition to existing fields. The GEP was implemented in #1002. Our existing documentation should be updated to explain the usage of the new field.
@cxhiano cxhiano added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 15, 2022
@cxhiano cxhiano mentioned this issue Feb 15, 2022
Merged
@robscott robscott added documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. and removed documentation Improvements or additions to documentation kind/feature Categorizes issue or PR as related to a new feature. labels Mar 14, 2022
@robscott robscott added this to the v1beta1 milestone Mar 14, 2022
@robscott
Copy link
Member

/assign @cxhiano

@rainest rainest mentioned this issue Mar 24, 2022
Closed
@cxhiano cxhiano mentioned this issue Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cxhiano cxhiano

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
v0.5.0
2 participants
@robscott @cxhiano