diff --git a/apis/v1alpha1/httproute_types.go b/apis/v1alpha1/httproute_types.go index 0f02b972be..102b81eb7e 100644 --- a/apis/v1alpha1/httproute_types.go +++ b/apis/v1alpha1/httproute_types.go @@ -357,8 +357,9 @@ type HTTPQueryParamMatch struct { // expressions. Please read the implementation's documentation to determine // the supported dialect. // - // HTTP query parameter matching MUST be case-sensitive for both keys and - // values. + // When the Exact QueryParamMatchType is used, HTTP query parameter matching + // MUST be case-sensitive for both keys and values. (See + // https://tools.ietf.org/html/rfc7230#section-2.7.3). // // +optional // +kubebuilder:default=Exact @@ -372,6 +373,9 @@ type HTTPQueryParamMatch struct { // // Multiple match values are ANDed together, meaning, a request must match // all the specified query parameters to select the route. + // + // Note that the query parameter key MUST always be an exact match by string + // comparison. Values map[string]string `json:"values"` } diff --git a/config/crd/bases/networking.x-k8s.io_httproutes.yaml b/config/crd/bases/networking.x-k8s.io_httproutes.yaml index 21a4acc24d..cecad3ff5d 100644 --- a/config/crd/bases/networking.x-k8s.io_httproutes.yaml +++ b/config/crd/bases/networking.x-k8s.io_httproutes.yaml @@ -739,9 +739,10 @@ spec: custom conformance, implementations can support POSIX, PCRE or any other dialects of regular expressions. Please read the implementation's documentation to - determine the supported dialect. \n HTTP query parameter + determine the supported dialect. \n When the Exact + QueryParamMatchType is used, HTTP query parameter matching MUST be case-sensitive for both keys and - values." + values. (See https://tools.ietf.org/html/rfc7230#section-2.7.3)." enum: - Exact - RegularExpression @@ -756,7 +757,9 @@ spec: key, and the value of the query parameter is the map value. \n Multiple match values are ANDed together, meaning, a request must match all the specified - query parameters to select the route." + query parameters to select the route. \n Note that + the query parameter key MUST always be an exact + match by string comparison." type: object required: - values