diff --git a/apis/v1alpha1/httproute_types.go b/apis/v1alpha1/httproute_types.go index 947f6d9f10..5e729b8e0f 100644 --- a/apis/v1alpha1/httproute_types.go +++ b/apis/v1alpha1/httproute_types.go @@ -361,9 +361,6 @@ type HTTPQueryParamMatch struct { // expressions. Please read the implementation's documentation to determine // the supported dialect. // - // HTTP query parameter matching MUST be case-sensitive for both keys and - // values. - // // +optional // +kubebuilder:default=Exact Type *QueryParamMatchType `json:"type,omitempty"` @@ -376,6 +373,12 @@ type HTTPQueryParamMatch struct { // // Multiple match values are ANDed together, meaning, a request must match // all the specified query parameters to select the route. + // + // HTTP query parameter matching MUST be case-sensitive for both keys and + // values. (See https://tools.ietf.org/html/rfc7230#section-2.7.3). + // + // Note that the query parameter key MUST always be an exact match by string + // comparison. Values map[string]string `json:"values"` } diff --git a/config/crd/bases/networking.x-k8s.io_httproutes.yaml b/config/crd/bases/networking.x-k8s.io_httproutes.yaml index 5bd808b23e..d64108b70d 100644 --- a/config/crd/bases/networking.x-k8s.io_httproutes.yaml +++ b/config/crd/bases/networking.x-k8s.io_httproutes.yaml @@ -742,9 +742,7 @@ spec: custom conformance, implementations can support POSIX, PCRE or any other dialects of regular expressions. Please read the implementation's documentation to - determine the supported dialect. \n HTTP query parameter - matching MUST be case-sensitive for both keys and - values." + determine the supported dialect." enum: - Exact - RegularExpression @@ -759,7 +757,11 @@ spec: key, and the value of the query parameter is the map value. \n Multiple match values are ANDed together, meaning, a request must match all the specified - query parameters to select the route." + query parameters to select the route. \n HTTP query + parameter matching MUST be case-sensitive for both + keys and values. (See https://tools.ietf.org/html/rfc7230#section-2.7.3). + \n Note that the query parameter key MUST always + be an exact match by string comparison." type: object required: - values