From 6bc2c8d2ae1c7cc9576f5040af151c6f98d726c9 Mon Sep 17 00:00:00 2001 From: toby cabot Date: Tue, 2 Aug 2022 09:20:20 -0400 Subject: [PATCH] Nit: fix markdown list formatting --- site-src/geps/gep-1058.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/site-src/geps/gep-1058.md b/site-src/geps/gep-1058.md index dff64808ea..7e5a2cfff1 100644 --- a/site-src/geps/gep-1058.md +++ b/site-src/geps/gep-1058.md @@ -451,6 +451,7 @@ To put this another way, an implementation *must* only modify `parents` entries ### Status additions The basic design: + - we'll add a `grandparents` stanza inside the parents stanza in status, which will contain details about the route being a parent, successfully or not. - the `grandparents` stanza will only be populated if a rule has a non-nil `allowedRoutes` section. - once the `grandparents` stanza is populated, Conditions are used to describe if the configuration still generates a valid Ephemeral Route configuration. @@ -472,6 +473,7 @@ status: - ``` We add a new `grandparents` stanza inside the the top-level `parents` status. This stanza will be `+optional` and `omitempty`, with the following rules: + - `grandparents` will be nil in all non-parent HTTPRoutes. - Once an HTTPRoute is a parent, then this stanza must also be non-nil. @@ -481,12 +483,12 @@ The struct itself has the same `parentRef` and `conditions` fields as the `paren The `parentRef` in the `grandparents` struct must be the same as the one on the *parent* Route's status. See the example for more clarity here. -For Conditions: -- when the controller first sees the parent Route, it must add the following Condition Types to the *parent* Route: - - `Attached`: one or more Routes have successfully attached to this parent. False if zero Routes have attached successfully. Note that a new Reason has also been added, `PartiallyAttached` which indicates that *some* routes have tried to attach and failed. - - `Conflicted`: one or more settings in the parent conflict with settings in one of the child routes. The message should contain more details. Routes that cause this to be true do not attach. - - `ResolvedRefs`: one or more Routes have failed to attach because there is a problem with their reference. (for example, they could not be found). Those routes do not attach. - - `NotSupported`: the controller that is reconciling this Route does not support attaching at least one of the routes that has attempted to attach, or the parent route is already a child route itself. Those routes do not attach. +For Conditions, when the controller first sees the parent Route it must add the following Condition Types to the *parent* Route: + +- `Attached`: one or more Routes have successfully attached to this parent. False if zero Routes have attached successfully. Note that a new Reason has also been added, `PartiallyAttached` which indicates that *some* routes have tried to attach and failed. +- `Conflicted`: one or more settings in the parent conflict with settings in one of the child routes. The message should contain more details. Routes that cause this to be true do not attach. +- `ResolvedRefs`: one or more Routes have failed to attach because there is a problem with their reference. (for example, they could not be found). Those routes do not attach. +- `NotSupported`: the controller that is reconciling this Route does not support attaching at least one of the routes that has attempted to attach, or the parent route is already a child route itself. Those routes do not attach. It must also add the same types to the *child* Route.