From 4d51132bf3f7b8a3c1809e292c9b2de5ad1698b3 Mon Sep 17 00:00:00 2001 From: Arko Dasgupta Date: Fri, 3 Mar 2023 08:16:33 -0800 Subject: [PATCH] incorporate Nick's suggestion Signed-off-by: Arko Dasgupta --- apis/v1beta1/httproute_types.go | 6 ++-- .../gateway.networking.k8s.io_httproutes.yaml | 34 +++++++++++++------ .../gateway.networking.k8s.io_httproutes.yaml | 34 +++++++++++++------ 3 files changed, 52 insertions(+), 22 deletions(-) diff --git a/apis/v1beta1/httproute_types.go b/apis/v1beta1/httproute_types.go index 3f029ad85c..acaff5994d 100644 --- a/apis/v1beta1/httproute_types.go +++ b/apis/v1beta1/httproute_types.go @@ -902,8 +902,10 @@ type HTTPRequestRedirectFilter struct { // Port is the port to be used in the value of the `Location` // header in the response. - // When empty, the Gateway listener port is used (except - // when it is a default port - 80 or 443). + // When empty, the Gateway Listener port is used. + // In all cases, when the protocol is http and the port is port 80, + // then the port must be omitted. Similarly, when the protocol is + // https and the port is port 443, then the port must also be omitted. // // Support: Extended // diff --git a/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml b/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml index 84309d0127..f7e329a58e 100644 --- a/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml +++ b/config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml @@ -571,9 +571,13 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the - response. When empty, the Gateway listener - port is used (except when it is a default - port - 80 or 443). \n Support: Extended" + response. When empty, the Gateway Listener + port is used. In all cases, when the protocol + is http and the port is port 80, then the + port must be omitted. Similarly, when the + protocol is https and the port is port 443, + then the port must also be omitted. \n Support: + Extended" format: int32 maximum: 65535 minimum: 1 @@ -1192,8 +1196,11 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the response. When empty, - the Gateway listener port is used (except when it - is a default port - 80 or 443). \n Support: Extended" + the Gateway Listener port is used. In all cases, + when the protocol is http and the port is port 80, + then the port must be omitted. Similarly, when the + protocol is https and the port is port 443, then + the port must also be omitted. \n Support: Extended" format: int32 maximum: 65535 minimum: 1 @@ -2428,9 +2435,13 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the - response. When empty, the Gateway listener - port is used (except when it is a default - port - 80 or 443). \n Support: Extended" + response. When empty, the Gateway Listener + port is used. In all cases, when the protocol + is http and the port is port 80, then the + port must be omitted. Similarly, when the + protocol is https and the port is port 443, + then the port must also be omitted. \n Support: + Extended" format: int32 maximum: 65535 minimum: 1 @@ -3049,8 +3060,11 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the response. When empty, - the Gateway listener port is used (except when it - is a default port - 80 or 443). \n Support: Extended" + the Gateway Listener port is used. In all cases, + when the protocol is http and the port is port 80, + then the port must be omitted. Similarly, when the + protocol is https and the port is port 443, then + the port must also be omitted. \n Support: Extended" format: int32 maximum: 65535 minimum: 1 diff --git a/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml b/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml index b28863e965..476e26b39d 100644 --- a/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml +++ b/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml @@ -494,9 +494,13 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the - response. When empty, the Gateway listener - port is used (except when it is a default - port - 80 or 443). \n Support: Extended" + response. When empty, the Gateway Listener + port is used. In all cases, when the protocol + is http and the port is port 80, then the + port must be omitted. Similarly, when the + protocol is https and the port is port 443, + then the port must also be omitted. \n Support: + Extended" format: int32 maximum: 65535 minimum: 1 @@ -899,8 +903,11 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the response. When empty, - the Gateway listener port is used (except when it - is a default port - 80 or 443). \n Support: Extended" + the Gateway Listener port is used. In all cases, + when the protocol is http and the port is port 80, + then the port must be omitted. Similarly, when the + protocol is https and the port is port 443, then + the port must also be omitted. \n Support: Extended" format: int32 maximum: 65535 minimum: 1 @@ -1871,9 +1878,13 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the - response. When empty, the Gateway listener - port is used (except when it is a default - port - 80 or 443). \n Support: Extended" + response. When empty, the Gateway Listener + port is used. In all cases, when the protocol + is http and the port is port 80, then the + port must be omitted. Similarly, when the + protocol is https and the port is port 443, + then the port must also be omitted. \n Support: + Extended" format: int32 maximum: 65535 minimum: 1 @@ -2276,8 +2287,11 @@ spec: port: description: "Port is the port to be used in the value of the `Location` header in the response. When empty, - the Gateway listener port is used (except when it - is a default port - 80 or 443). \n Support: Extended" + the Gateway Listener port is used. In all cases, + when the protocol is http and the port is port 80, + then the port must be omitted. Similarly, when the + protocol is https and the port is port 443, then + the port must also be omitted. \n Support: Extended" format: int32 maximum: 65535 minimum: 1