Updates service dns doc to refer to issue 370 and gke clusters #453
Conversation
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
cncf-cla: yes
|
/cc @shashidharatd |
docs/servicedns-with-externaldns.md
Outdated
| @@ -42,7 +42,8 @@ providers. | |||
| Setting-up MCSDNS can be accomplished by referencing the following documentation: | |||
|
|
|||
| - The Federation-v2 [User Guide](userguide.md) to setup one or more Kubernetes clusters and the Federation | |||
| control-plane. If running in GKE, the cluster hosting the ExternalDNS controller must have scope | |||
| control-plane. Due to [Issue #370](https://github.com/kubernetes-sigs/federation-v2/issues/370) you can not use minikube | |||
There was a problem hiding this comment.
I think we can still use minikube here as long as we can enable the minikube support service type LoadBalancer, how about make the limitation to NodePort but not minikube?
There was a problem hiding this comment.
I thought type LoadBalancer was not supported by minikube. It looks like kubernetes/minikube#3015 adds support for this type. I wanted to call out minikube specifically, since some people don't realize that minikube uses NodePort to expose services.
There was a problem hiding this comment.
But after I install minikube, I can still deploy a helm chart like keepalived here https://github.com/gyliu513/work/tree/master/k8s/charts/keepalived and enable the minikube support LoadBalancer type, am I missing anything?
There was a problem hiding this comment.
one could also use metallb to provision LoadBalancers in minikube clusters.
There was a problem hiding this comment.
From my understanding, you can not use minikube without additional tooling such as metallb or keepalived to support LoadBalancer. However, I get your point and will update the doc to remove the minikube reference.
danehans
force-pushed
the
svc_dns_doc
branch
from
e1d2ce1
to
99f5f79
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, gyliu513 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adds details about required cluster type (i.e. GKE) and sample service type due to #370.