Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple identically-named zones #335

Closed
coreypobrien opened this issue Sep 13, 2017 · 3 comments
Closed

Support multiple identically-named zones #335

coreypobrien opened this issue Sep 13, 2017 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@coreypobrien
Copy link
Contributor

coreypobrien commented Sep 13, 2017

In some cases, multiple identically-named zones exist for a single record. For example, an "example.com" private zone may be associated with a VPC in addition to a public "example.com" hosted zone. The ideal behavior for external-dns would be to update records for both the public zone (so that the record is publicly resolvable) and the private zone (so the record is resolvable inside the VPC).

Currently, the implementation of suitableZone (or its equivalent in other providers) returns only 1 longest-matching zone. I propose changing the default implementation to return a list of any longest-matching zones. The providers can then write the record to all of the zones returned.

As a part of changing this, we can tackle the consolidation of the suitable-zone logic for #228.

@hjacobs hjacobs added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 13, 2017
@coreypobrien
Copy link
Contributor Author

The private hosted zones feature in AWS is actually semi-unique amongst the supported DNS providers. Supporting multiple results from suitableZone is actually a good example of AWS needing a specific implementation instead of a generic one. I'm removing the desire to consolidate that functionality from this issue.

@coreypobrien
Copy link
Contributor Author

@njuettner @linki I'm curious to get your feedback on this and the work in #356. It conflicts with #263. I'd like to remove AWS from the consolidation since private hosted zones need to be treated differently. What do you all think?

@Shemeikka
Copy link

Hi,

What's the status of this issue/feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants