-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for registering Pod IPs #195
Comments
@linki, any plans on supporting this or Headless service? Without either of these, folks on bare metal cluster can't really use external-dns. |
I think this is a duplicate of #315 and might be closed? |
@hjacobs If I understand this correctly, the #315 is doing something else. Right now there are two possibilities:
I think what OP wants (and what we would need as well) is:
We currently would need that because we are terminating TLS in the pods, so we need a valid hostname on the pod itself. |
I was interpreting this differently. I want to register the IP of all pods in DNS so that the client will connect to one of the pods. Basically a poor man's load balancing. So if I have pods on |
But this is already working? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Add helpers for paths of plugin receipts * Add google/go-cmp for expressive diffs in test assertions * Remove plugin receipt on uninstall * Save plugin manifest in receipt directory * Load plugin manifest from receipts directory or the index * Do not expect specific folder layout in LoadPluginFileFromFS * Fix godoc for environment paths * Review comments * Swap plugin install and saving receipts Saving receipts is less prone to failure than the whole plugin installation. When swapped, krew will have an inconsistent state in fewer occasions. * Add test to ensure LoadManifestFromReceiptOrIndex returns ENOENT error when plugin does not exist * Put receipts in folder 'receipts' instead of 'receipts/krew-index' * Fix linter issues * Rename ReceiptsPath -> InstallReceiptPath * Save the new install receipt when upgrading a plugin
Triggered by #187 @hjacobs came up with the idea of a
PodSource
instead of scrapingServices
forEndpoints
.One could annotate a Pod (or more likely, a
PodSpec
in aDeployment
) with a desired hostname or afqdn-template
.ExternalDNS could find them and add their Pod IPs to the DNS provider. In this case three A records pointing to the three pods.
Why not use Headless Services?
The text was updated successfully, but these errors were encountered: