Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor kubernetes v1.17.0 #561

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Vendor kubernetes v1.17.0 #561

merged 1 commit into from
Dec 11, 2019

Conversation

saschagrunert
Copy link
Member

Refers to #558

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2019
@feiskyer
Copy link
Member

crictl e2e failed:

Summarizing 5 Failures:
[Fail] crictl: info [It] should succeed 
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/test/framework/framework.go:108
[Fail] crictl: pull [It] should succeed without tag or digest 
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/test/framework/framework.go:108
[Fail] crictl: pull [It] should succeed with digest 
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/test/framework/framework.go:108
[Fail] crictl: version [It] should succeed 
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/test/framework/framework.go:108
[Fail] crictl: pull [It] should succeed with tag 
/home/travis/gopath/src/github.com/kubernetes-sigs/cri-tools/test/framework/framework.go:108
Ran 12 of 12 Specs in 139.694 seconds
FAIL! -- 7 Passed | 5 Failed | 0 Pending | 0 Skipped

@saschagrunert
Copy link
Member Author

I see, an update of CRI-O and conmon should do the trick 👍

@saschagrunert saschagrunert force-pushed the k8s-1.17 branch 2 times, most recently from 844c75b to 0bde422 Compare December 10, 2019 14:33
@saschagrunert
Vendor kubernetes v1.17.0
84a4dce 
Signed-off-by: Sascha Grunert <[email protected]>
feiskyer
feiskyer reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [feiskyer,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f6eb4c into kubernetes-sigs:master Dec 11, 2019
@saschagrunert saschagrunert deleted the k8s-1.17 branch December 11, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @feiskyer @k8s-ci-robot