Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download golangci-lint via wget #552

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Download golangci-lint via wget #552

merged 6 commits into from
Nov 7, 2019

Conversation

haircommander
Copy link
Contributor

@haircommander haircommander commented Nov 7, 2019 •
edited
Loading

Kubernetes now requires golang 1.13.4. When using golang 1.13.4 to build critest, we run into golangci-lint#659. Fix this with a couple of changes:

  • install the golangci-lint binary for 1.17.1 with curl (similar to how CRI-O currently does), instead of using go mods
    • this includes dropping golangci-lint on ppc (which shouldn't matter)
    • which also includes breaking make install.tools into two different targets: lint and ginkgo
  • bump the go version used by travis to 1.13 (because kubelet now requires 1.13.4 to build)
  • revendor cri-tools with golang 1.13 (using the command: podman run --privileged --rm --env HOME=/root -v $PWD:/src -w /src golang:1.13 make vendor)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @haircommander!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2019
@haircommander haircommander mentioned this pull request Nov 7, 2019
Merged
@haircommander
Copy link
Contributor Author

@saschagrunert @mrunalp @Random-Liu PTAL

@saschagrunert
Copy link
Member

Ah, interesting. Can we remove it from vendoring at all and just download the binary via the curl script, like we do in CRI-O? I recently hit compilation issues with golangci-lint and they recommend to use their prebuilt ones.

@haircommander
Copy link
Contributor Author

@saschagrunert good idea, fixed!

@haircommander haircommander changed the title bump to golangci-lint 1.19.1 Download golangci-lint via wget Nov 7, 2019
saschagrunert
saschagrunert reviewed Nov 7, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
saschagrunert
saschagrunert approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert
Copy link
Member

@haircommander we have to exclude the golangci lint check for travis on ppc, because it is not supported right now. :-/

@saschagrunert
Copy link
Member

@mrunalp @feiskyer @Random-Liu PTAL

@haircommander
Download golangci-lint via wget
a5e9868 
Kubernetes now requires golang 1.13.4. When using golang 1.13.4 to build critest, we run into golangci-lint#659. Fix this by installing the golangci-lint binary for 1.17.1 with curl (similar to how CRI-O currently does), instead of using go mods.

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
bump to golangci-lint 1.21.0
9fb8882 
Signed-off-by: Peter Hunt <[email protected]>
@haircommander
don't lint on ppc as golangci-lint isn't built there
07832e6 
Signed-off-by: Peter Hunt <[email protected]>
saschagrunert
saschagrunert reviewed Nov 7, 2019
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
@haircommander
vendor using go 1.13
2018721 
Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Contributor Author

huzzah, (finally) green tests. @mrunalp @feiskyer @Random-Liu PTAL

@mrunalp
Copy link
Member

mrunalp commented Nov 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@mrunalp
Copy link
Member

mrunalp commented Nov 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit f8a6b3d into kubernetes-sigs:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haircommander @k8s-ci-robot @saschagrunert @mrunalp