Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a dedicated image for all reference test. #503

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

Random-Liu
Copy link
Contributor

Both image tag test and all image reference test are using the same image. It will cause issue when running CRI validation test in parallel.

This PR:

  1. Add a new image test-image-tag:all and use it in the all reference image test;
  2. Simplify the image build code;
  3. Add username and password for manifest-tool;

@feiskyer Do you have a windows environment to build the windows image? Thanks!

Signed-off-by: Lantao Liu [email protected]

@k8s-ci-robot k8s-ci-robot requested a review from yujuhong August 9, 2019 08:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2019
@feiskyer
Copy link
Member

@feiskyer Do you have a windows environment to build the windows image? Thanks!

Yep, I can build these images.

@feiskyer
Copy link
Member

Let's get this merged. I would build the windows images after this.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Random-Liu,feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e589a1e into kubernetes-sigs:master Aug 15, 2019
@feiskyer
Copy link
Member

Windows images are built and pushed. But there're some errors for image-test:

docker push gcr.io/cri-tools/test-image-tag-amd64:1; docker push gcr.io/cri-tools/test-image-tag-amd64:2; docker push gcr.io/cri-tools/test-image-tag-amd64:3;
The push refers to repository [gcr.io/cri-tools/test-image-tag-amd64]
tag does not exist: gcr.io/cri-tools/test-image-tag-amd64:1
The push refers to repository [gcr.io/cri-tools/test-image-tag-amd64]
tag does not exist: gcr.io/cri-tools/test-image-tag-amd64:2
The push refers to repository [gcr.io/cri-tools/test-image-tag-amd64]
tag does not exist: gcr.io/cri-tools/test-image-tag-amd64:3
Makefile:32: recipe for target 'sub-push-amd64' failed
make: *** [sub-push-amd64] Error 1

@Random-Liu Could you fix these errors and build the Linux images again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants