Update rmp to test for running sandbox
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
feiskyer
reviewed
May 29, 2019
cmd/crictl/sandbox.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if !ctx.Bool("force") && |
There was a problem hiding this comment.
if force is true and sandbox state is READY, then invoke StopPodSandbox() before RemovePodSandbox?
There was a problem hiding this comment.
Yes that sounds good, I will change it as adapted.
Running pod sandboxes have to be stopped before the actual removal. To achieve a better user-experience, we now error in that case and give the user the option to ignore it with the added `-f` flag for `rmp`. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
The CI has been passed from travis page, but didn't reflect the status from github hook. Merged this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running pod sandboxes have to be stopped before the actual removal. To
achieve a better user-experience, we now error in that case and give the
user the option to ignore it with the added
-fflag forrmp.Closes #464