Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering the pods with prefix matching of name and namespace #332

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Allow filtering the pods with prefix matching of name and namespace #332

merged 2 commits into from
Jun 28, 2018

Conversation

yujuhong
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2018
@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2018
@Random-Liu
Copy link
Contributor

Can we change to regular expression instead? Seems more useful. :)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2018
@yujuhong
Copy link
Contributor Author

Can we change to regular expression instead? Seems more useful. :)

Done. PTAL

@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
@Random-Liu Random-Liu modified the milestones: v1.11.0, v1.11.1 Jun 28, 2018
@feiskyer
Copy link
Member

lgtm

@feiskyer feiskyer merged commit 3bf77bf into kubernetes-sigs:master Jun 28, 2018
@Random-Liu Random-Liu mentioned this pull request Jul 11, 2018
Merged
feiskyer added a commit that referenced this pull request Jul 11, 2018
@feiskyer
Merge pull request #338 from Random-Liu/cherrypick-#332
fdd62fa 
Cherrypick #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11.1
Development

Successfully merging this pull request may close these issues.
4 participants
@yujuhong @feiskyer @Random-Liu @k8s-ci-robot