Add new container host path test. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This was referenced Jun 4, 2018
|
It seems that standalone dockershim doesn't work now. Will investigate later. |
|
Yep, kubelet --experimental-dockershim will exit silently. Let me file a PR to fix that |
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
add-new-volume-test
branch
from
21c65b0 to
b5dda7e
Compare
|
Removed the non-existent host path test. Let's finalize kubernetes/kubernetes#61460 (comment) first. |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jun 6, 2018
Automatic merge from submit-queue (batch tested with PRs 64749, 64797). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix standalone dockershim. Ref kubernetes-sigs/cri-tools#320 (comment). This PR fixes a bug that standalone dockershim exits immediately. This PR: 1) Changes standalone dockershim to wait on `stopCh`, so that it won't exit immediately. 2) Removes `stopCh` from dockershim internal. It doesn't help much for graceful stop, because kubelet will exit immediately anyway. https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L748 @kubernetes/sig-node-pr-reviews @yujuhong @feiskyer **Release note**: ```release-note none ```
|
@feiskyer Please take a look. This PR only adds symlink host path test now. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CRI validation test to conform to kubernetes/kubernetes#61460.
Signed-off-by: Lantao Liu [email protected]