Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI log parser improvements #232

Merged
merged 2 commits into from
Feb 8, 2018
Merged

CRI log parser improvements #232

merged 2 commits into from
Feb 8, 2018

Conversation

jreyeshdez
Copy link
Contributor

→ Possible fix for #228 :

  • Modified parseCRILog to use strings.SplitN instead of multiple calls to strings.Fields.
  • Check the resulting array to make sure it has the correct or the expected size and avoid errors when accessing different fields.

@jreyeshdez
CRI log parser improvements
4bf97d9 
- Modified [`parseCRILog`](https://github.com/kubernetes-incubator/cri-tools/blob/bb2c5293bfa6dd5207e1ce3f2d5a32b09f1cc549/pkg/validate/container.go#L431) to use `strings.SplitN` instead of multiple calls to `strings.Fields`.
- Check the resulting array to make sure it has the correct or the expected size and avoid errors when accessing different fields.
@jreyeshdez
CRI log parser improvements
65725c8 
- Modified [`parseCRILog`](https://github.com/kubernetes-incubator/cri-tools/blob/bb2c5293bfa6dd5207e1ce3f2d5a32b09f1cc549/pkg/validate/container.go#L431) to use `strings.SplitN` instead of multiple calls to `strings.Fields`.
- Check the resulting array to make sure it has the correct or the expected size and avoid errors when accessing different fields.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2018
feiskyer
feiskyer reviewed Feb 7, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@feiskyer
Copy link
Member

feiskyer commented Feb 7, 2018

@Random-Liu Would you like to take another look?

@Random-Liu
Copy link
Contributor

@feiskyer No. I trust you. :D

@feiskyer feiskyer merged commit 653cc8c into kubernetes-sigs:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jreyeshdez @feiskyer @Random-Liu @k8s-ci-robot