Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crictl config cannot set debug to false #440

Closed
liujing66 opened this issue Mar 6, 2019 · 1 comment · Fixed by #466
Closed

Crictl config cannot set debug to false #440

liujing66 opened this issue Mar 6, 2019 · 1 comment · Fixed by #466

Comments

@liujing66
Copy link

Issue Description:
When I tested the sub option of crictl config, I found that "crictl config" cannot set debug to false。

crictl config --get debug

true

crictl config debug false

FATA[0000] use true|false for debug

It seems like a bug,the code 118-129 lines ,the if statement is missing the setting for value=“false”
case "debug":
var debug bool
if value == "true" {
debug = true
} else {
logrus.Fatal("use true|false for debug")
}
config.Debug = debug

My crio verison is:

crictl version

Version: 0.1.0
RuntimeName: cri-o
RuntimeVersion: 1.12.0-dev
RuntimeApiVersion: v1alpha1

@Random-Liu
Copy link
Contributor

Feel free to send a fix for the bug. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants