Skip to content

Commit

Permalink
pkg: validate: validate Username not empty in ImageStatus
Browse files Browse the repository at this point in the history
Kubernetes rely on that Username field to provide RunAsUser, we need to
validate runtimes correctly return it. We had recently an issue in
CRI-O for that.

Signed-off-by: Antonio Murdaca <[email protected]>
  • Loading branch information
runcom committed Feb 15, 2018
1 parent c87ea76 commit 33877da
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions pkg/validate/image.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ var _ = framework.KubeDescribe("Image Manager", func() {
Expect(status.Size_).NotTo(BeNil(), "Image Size should not be nil")
})

It("image status get image fields should not have Username empty [Conformance]", func() {
// runcom/testnginx has been built with a dockerfile having USER 1002
// we test that that user is returned in image status
framework.PullPublicImage(c, "runcom/testnginx")

defer removeImage(c, "runcom/testnginx")

status := framework.ImageStatus(c, testImageRef)
Expect(status.Username).NotTo(BeNil(), "Image Username should not be empty")
Expect(status.Username).To(Equal("1002"), "Image Username should be 1002")
})

It("listImage should get exactly 3 image in the result list [Conformance]", func() {
// different tags refer to different images
testImageList := []string{
Expand Down

0 comments on commit 33877da

Please sign in to comment.