-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken resource kind logging #1945
Comments
That's interesting, but I'm not sure how can we convert to lower cases like this.. |
Why not just log kind as is? If key must start with a lower case letter, then make entire kind in lower case and log it. |
Actually I don't think this line is necessary since the namespace and name will also be values. |
@sbueringer WDYT |
I just went ahead and made #1954 |
Missed this issue. I answered here: #1954 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#1827 introduced this funny bug that kind is logged in unexpected way.
More specifically,
controller-runtime/pkg/builder/controller.go
Line 318 in ffd9ec8
If gvk.Kind is "APIService", I expect "apiService", but the current code produces and logs "aPIService".
The text was updated successfully, but these errors were encountered: