Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tool output should be alphabetically sorted irrespective of their upper/lower case #9010

Closed
Tracked by #9008
nawazkh opened this issue Jul 18, 2023 · 2 comments · Fixed by #9055
Closed
Tracked by #9008
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nawazkh
Copy link
Member

nawazkh commented Jul 18, 2023

What steps did you take and what happened?

The output of the release tool , although sorted, segregates uppercase prefixed PRs and lowercase prefixed PRs.
Example:

.
.
Devtools: tilt: set CR logger in tilt-prepare, fix allowed contexts
IPAM: ipam: fix gateway being required for IPAddress 
KCP: Allow machine rollout if cert reconcile fails
.
.
e2e: test/e2e check for machines being ready after provisioning on Runtime SDK test 
e2e: test/e2e: use topology cluster-template for clusterctl upgrade mgmt cluster
.
.

What did you expect to happen?

We would want to club all the PRs together and sort them irrespective of the case of the prefix of the PR.
The output should look like

.
.
Devtools: tilt: set CR logger in tilt-prepare, fix allowed contexts
e2e: test/e2e check for machines being ready after provisioning on Runtime SDK test 
e2e: test/e2e: use topology cluster-template for clusterctl upgrade mgmt cluster
IPAM: ipam: fix gateway being required for IPAddress 
KCP: Allow machine rollout if cert reconcile fails
.
.

Cluster API version

unrelated to CAPI version

Kubernetes version

unrelated to K8s version

Anything else you would like to add?

Should be part of #9008

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2023
@killianmuldoon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2023
@Dhairya-Arora01
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants